Get skyrim working again - #71
Open
W-Drew wants to merge 4 commits into
Open
Conversation
W-Drew
added a commit
to W-Drew/nifskope
that referenced
this pull request
Dec 28, 2023
PR to upstream: hexabits#71
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current release of NifSkop cannot save bhkCompressedMeshShapeData in Skyrim meshes as reported by #67. The current develop branch has also drifted from the nif.xml the latest release is using and spews various warnings when a binary built from develop is used without first updating the nif.xml. This PR makes the following changes:
Bug with bhkCompressedMeshShapeData is fixed as described by @Candoran2 in [Dev 9] Error saving some files with CMS collision #67. It was a small issue introduced in 1365ca1d6d68a6b3d18efe1c5c43a7c605313939 where we told Qt to write 6 bytes but that we wanted 3 bytes in return. Updated to expect 6 bytes in return
Checked in the nif.xml from the current release to source control as-is with no edits
Upstream @Candoran2's build file. Getting Nifskope to build took a lot of troubleshooting since it was unclear which versions of Qt & VS toolchain were being used to build the latest releases and older versions of Qt/VS toolchain would fail to build. With this, there is no longer ambiguity.
Add vscode's local files to gitignore